Skip to content

Fix css for login page has external login #19843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NguyenThuyLan
Copy link
Contributor

This PR fixes for the issue #19628

@AndyButland
Copy link
Contributor

I'm still seeing a border on the screen when you have external login's configured @NguyenThuyLan:

image

It's a bit weird, as it's not always there. If I inspect the element it disapears but if I click back on the screen it comes back. So I don't think it's caching. I don't see this once I click to "Sign in with Umbraco".

@iOvergaard
Copy link
Contributor

The border is coming from the native <dialog /> element in the browser, I believe (MDN seems to confirm this). The screen with external login is technically a modal/dialog. You would probably need to interact directly with that element, and that may be hidden inside the <uui-popover-container /> element.

@NguyenThuyLan
Copy link
Contributor Author

@iOvergaard I'm not sure how to fix this? Can you give me an example?
I can see it is affected by :focus-visible

@iOvergaard
Copy link
Contributor

@NguyenThuyLan uui-popover-container is something in the UI library, so the styling would need to go there. However, we cannot change all modals in the system to make this work. It is something of a "hack" to use the modal system to open the login form on top of the backoffice.
Perhaps it would be better suited to implement a native popover element just for the login form (with its own styling) rather than relying on UUI components.

This is the inner modal element: src/Umbraco.Web.UI.Client/src/packages/core/auth/modals/umb-app-auth-modal.element.ts

It is opened in UmbAppAuthController on line 130:

const selected = await modalManager
.open(this._host, UMB_MODAL_APP_AUTH, {
data: {
userLoginState,
},
modal: {
key: authModalKey,
backdropBackground: 'var(--umb-auth-backdrop, rgb(244, 244, 244))',
},
})
.onSubmit()
.catch(() => undefined);

What if, instead of using the modal manager, we opened the element as a native popover, where we would be in control of the styling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants